fix: allow path ending with .html to fallback to index.html

vitejs · Sep 29, 2023 · dae6d0a · dae6d0a
1 parent ec7ee22
commit dae6d0a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/vite/src/node/server/middlewares/htmlFallback.ts b/packages/vite/src/node/server/middlewares/htmlFallback.ts
@@ -26,11 +26,16 @@ export function htmlFallbackMiddleware(
           return spaFallback ? `/index.html` : request.url
         },
       },
-      // don't rewrite paths ending with .html
       {
         from: /\.html$/,
-        to({ request }: any) {
-          return request.url
+        to({ parsedUrl, request }: any) {
+          // .html files are not handled by serveStaticMiddleware
+          // so we need to check if the file exists
+          const pathname = decodeURIComponent(parsedUrl.pathname)
+          if (fs.existsSync(path.join(root, pathname))) {
+            return request.url
+          }
+          return '/index.html'
         },
       },
     ],

diff --git a/playground/assets/__tests__/assets.spec.ts b/playground/assets/__tests__/assets.spec.ts
@@ -52,6 +52,10 @@ test('should get a 404 when using incorrect case', async () => {
   )
 })
 
+test('should fallback to index.html when accessing non-existant html file', async () => {
+  expect((await fetchPath('doesnt-exist.html')).status).toBe(200)
+})
+
 describe('injected scripts', () => {
   test('@vite/client', async () => {
     const hasClient = await page.$(