Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve as https #194

Closed
psi-4ward opened this issue May 19, 2020 · 3 comments · Fixed by #208
Closed

serve as https #194

psi-4ward opened this issue May 19, 2020 · 3 comments · Fixed by #208
Labels

Comments

@psi-4ward
Copy link

Due to avoid various permissions problems it is often good to develop under https so can we add this feature?

underfin added a commit to rolldown/vite that referenced this issue May 20, 2020
@psi-4ward
Copy link
Author

impressive !!!

@CharlesOkwuagwu
Copy link

This is cool, but we might also need to register the certs on the local machine.

Is there a way the certs generated can be written to a ./certs folder, from where the developer may opt to install them to their local machine?

Also, the certs could be re-used across multiple Vite projects, and not regenerated on each npm run Vite.

Finally, Vite knows the local network IP addresses on that machine, adding these to the list of altNames on the cert would be useful.

https://github.com/vitejs/vite/blob/master/src/node/utils/createCertificate.ts#L29-L34

Dev server running at:
  > Network:  https://192.168.2.4:3000/
  > Network:  https://192.168.43.154:3000/
  > Local:    https://localhost:3000/

image

@underfin
Copy link
Member

@CharlesOkwuagwu. Cert will created into server.pem. see #276.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants