Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(importGlob): don't warn when CSS default import is not used #11121

Merged
merged 6 commits into from
Nov 30, 2022
Merged

fix(importGlob): don't warn when CSS default import is not used #11121

merged 6 commits into from
Nov 30, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 29, 2022 •
edited
Loading

Description

I implemented #11103 (comment) by moving the warning to runtime.
Since we only output the warning only on dev, I think we could move it.

This PR will change a property to getter. Though, I think this change won't break things most of the time.

refs #11094 #11103

Additional context

Note that sourcemap is currently broken. See #11122.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 29, 2022
@sapphi-red sapphi-red added this to the 4.0 milestone Nov 29, 2022
@sapphi-red sapphi-red requested a review from bluwy November 29, 2022 16:42
bluwy
bluwy reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat trick. Only one comment for cleanup but this is much nicer DX-wise.

packages/vite/src/node/__tests__/plugins/importGlob/fixture.test.ts Show resolved Hide resolved
@patak-dev patak-dev merged commit 97f8b4d into vitejs:main Nov 30, 2022
@sapphi-red sapphi-red deleted the fix/import-glob-css-defaut-import-warning branch November 30, 2022 07:13
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
fix(importGlob): don't warn when CSS default import is not used (vite…
4991018 
…js#11121)
@caghand caghand mentioned this pull request Mar 6, 2023
Closed
7 tasks
@sapphi-red sapphi-red mentioned this pull request Aug 16, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @bluwy @patak-dev