fix: use relative source path in sourcemapIgnoreList

[patak-dev]

Description

Context #12251 (comment)

Calls to sourcemapIgnoreList for vite dev on a create-vite vue ts app after this change

sourcePath: overlay.ts
sourcemapPath: /Users/patak/vite-work/packages/vite/dist/client/client.mjs.map

sourcePath: client.ts
sourcemapPath: /Users/patak/vite-work/packages/vite/dist/client/client.mjs.map

sourcePath: main.ts
sourcemapPath: /Users/patak/test/sourcemap-test/src/main.ts.map

sourcePath: env.ts
sourcemapPath: /Users/patak/vite-work/packages/vite/dist/client/env.mjs.map

sourcePath: App.vue
sourcemapPath: /Users/patak/test/sourcemap-test/src/App.vue.map

sourcePath: HelloWorld.vue
sourcemapPath: /Users/patak/test/sourcemap-test/src/components/HelloWorld.vue.map

cc @bmeurer @danielroe @bluwy

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[danielroe]

If this is meant to align with rollup, I'm not sure this is the same thing rollup is doing with regard to the relative paths. Personally, I think absolute sourcePath is more useful for this particular function.

[patak-dev]

This is the same run with rollup:

sourcePath: ../../node_modules/.pnpm/@[email protected]/node_modules/@vue/shared/dist/shared.esm-bundler.js
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../node_modules/.pnpm/@[email protected]/node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../node_modules/.pnpm/@[email protected]/node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../node_modules/.pnpm/@[email protected]/node_modules/@vue/runtime-dom/dist/runtime-dom.esm-bundler.js
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../../../../../vite.svg
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../src/assets/vue.svg
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../src/components/HelloWorld.vue
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

sourcePath: ../../src/main.ts
sourcemapPath: /Users/patak/test/sourcemap-test/dist/assets/index-!~{001}~.js.map

IIUC, sourcePath is the source relative to the sourcemapPath in rollup. For the dev server, because we mostly have a 1:1 sourcemap to source relationship and the sourcemapPath ends up coinciding with the module, if we align with Rollup as we do in this PR, that would mean that the sourcePath would generally be the filename. So users would mainly need to use sourcemapPath for the condition.

I'm ok if we decide to use absolute paths here, I agree that for the dev server, it is a lot more ergonomic.

[bmeurer]

I also think that having absolute paths here is the right thing to do here. If we learn in the future that it'd be beneficial to have (project) relative paths, and there are concrete use cases that don't work with absolute paths, we can always go back and re-investigate.

[patak-dev]

@bluwy if you are ok too with keeping absolute paths, I'll close this PR.

[bluwy]

If we have 2 votes going with absolute paths, then I guess we could leave it then 😄 It might be good to note in the docs of the difference with rollup too, and/or note that they are absolute paths by default.

[bmeurer]

If we have 2 votes going with absolute paths, then I guess we could leave it then 😄 It might be good to note in the docs of the difference with rollup too, and/or note that they are absolute paths by default.

+1 to updating the docs

[patak-dev]

Ok, I'll send later a PR to clarify that. And we could force absolute path too. Right now, the paths for client.ts and overlay.ts are relative.