perf(chokidar): avoid fs calls on ignored files #12584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are will be some extra fs calls on the ignored files (e.g especially when generating
.vite
cache) in chokidar. I think we could optimize it. But I also notice that https://github.com/paulmillr/chokidar is less active now, so maybe we can add apnpm patch
for it.This pr will avoid unnecessary calculations when ignored files change. I tested https://github.com/Lani/vite-2.7-slow before and after this pr. There will be 20-50ms faster after this pr when initial startup.
Additional context
I will send a PR to fix this upstream later. And once it gets merged, we can revert this and upgrade chokidar to the new one.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).