refactor: use simpler resolve for nested optimized deps #12770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
tryFsResolve
tries to matchid
tofoo > bar
syntaxes, useresolvePackageData
instead of theresolve
dep to match paths.We don't actually need to do a full resolve as matching with
startsWith
is sufficient in most case. It is even riskier doing a full resolve as the resolve algorithim inresolve
can differ from Vite's resolver algorithm used to deriveoptimizedData.src
. (Partly an issue being solved in #11410)This PR also removes the
resolve
dep 🎉 It needs a tweak topostcss-import
as it importsresolve
too (which otherwise would've bundledresolve
), but we're able to avoid that as explained in the comments.Additional context
I'm trying to fix #11410, and figured to do this change as a stop gap as the next changes will be a bit large.
Existing tests should pass.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).