Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): use --open in dev script #12811

Closed
wants to merge 1 commit into from

Conversation

patak-dev
Copy link
Member

Description

After we merge #12809, vite --open will be a lot faster than vite then click on the URL in CLI. I think we should encourage users to use --open, and having it in our starter templates is a good way to do so.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Apr 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the performance Performance related enhancement label Apr 10, 2023
@ArnaudBarre
Copy link
Member

We should do a pool to know if this should be the default in V5 (along with preview).
I personally enabled it on all my projects

@patak-dev
Copy link
Member Author

@ArnaudBarre here is a poll in Twitter and in Mastodon. Folks are sharing good reasons to keep --open as opt-in in the comments.

@patak-dev
Copy link
Member Author

Given the reactions in the polls, it is clear that vite --open by default isn't a good idea. And I think maybe we should also ditch this PR.

@ArnaudBarre
Copy link
Member

With a flag so visible in the dev script I think this is very easy to "opt-out" and nice for discovering Vite. But a single line in the readme could also do.

@usercao
Copy link

usercao commented Apr 13, 2023

I really hope the official can add vite --open because I have to manually add it every time I open a new project.

@patak-dev
Copy link
Member Author

I'm going to close this one, as it isn't clear that we should push --open by default even for templates. Currently leaning towards adding tips in the readme of the starters. We can revisit this once we merge #12809

@patak-dev patak-dev closed this May 24, 2023
@patak-dev patak-dev deleted the feat/use-open-in-create-vite-templates branch March 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants