Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): dev mode reduce unnecessary restart #14426

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 21, 2023

Description

I don't think it's necessary to restart the server to modify the production environment related env in development mode.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry only checked now.
Could you expose something like getEnvFilesForMode in env.ts that expose this list?
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/env.ts#L21-L26
Then changeEnvShouldRestart can be replaced by getEnvFilesForMode(mode).includes(filename)

@patak-dev
Copy link
Member

This is an interesting optimization. My only doubt is if users may expect other .env files they access manually in the config to trigger a server restart. Maybe this is how it should work though and the user needs to manually force a restart for these files.

@ArnaudBarre
Copy link
Member

Personally I think this is better to show to the user that .env.prod changes doesn't have impact on the running dev server

@patak-dev
Copy link
Member

Personally I think this is better to show to the user that .env.prod changes doesn't have impact on the running dev server

Sounds good to me. I let others also do a review and merge this one

@bluwy bluwy added feat: hmr p2-nice-to-have Not breaking anything but nice to have (priority) labels Sep 28, 2023
@bluwy bluwy merged commit 6f9d39d into vitejs:main Sep 28, 2023
@btea btea deleted the fix/hmr-reduce-restart branch September 28, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants