feat(server): add warmupRequest api #14787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p2-nice-to-have
|
|
|
I think this is a great idea, and would enable us to push for more frameworks to have warmup strategies (with proper context). About the API, I think it is better to have a new function |
patak-dev
approved these changes
Oct 31, 2023
bluwy
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
warmupoption toserver.transformRequestto prevent internal code-duplication, and potential external uses like #14777Also snuck adding pre-transform support for HMR soft invalidation, as the soft invalidation fast-path doesn't run through import analysis.
Additional context
What is the purpose of this pull request?