fix(types): mark hmr update internal types optional #15606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HMR update type can be manually emitted today like https://github.com/histoire-dev/histoire/blob/bc08dec376faa9f72335f6fa4c54283a0233a93d/packages/histoire/src/node/server.ts#L102, which broke types downstream. Marking them as optional like before for now. (
explicitImportRequired
was already optional before but I made it required in #15118Currently these internal types are only used at
vite/packages/vite/src/client/client.ts
Lines 142 to 165 in fdc142c
Additional context
Thanks @Akryum for spotting this.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).