Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor hmr-ssr tests #18075

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

sapphi-red
Copy link
Member

Description

This PR contains the following changes:

  • remove util functions declared in hmr-ssr.spec.ts and use the same functions declared in test-utils.ts
    • also run the tests in playground-temp
  • only run hmr-ssr test on test-serve (dont run it on test-build) because the tests only makes sense for serve
  • removed todo from tests and fixed to make them passing
  • removed todo tests that are not relevant for SSR

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Sep 11, 2024
Copy link

stackblitz bot commented Sep 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patak-dev patak-dev merged commit e7d51a3 into vitejs:main Sep 12, 2024
12 checks passed
@sapphi-red sapphi-red deleted the refactor/hmr-ssr-tests branch September 17, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants