Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix server-worker-runner flaky test #18247

Merged

Conversation

sapphi-red
Copy link
Member

Description

#18237 did not fix it completely.
There's many circular deps in our code base 😅
For now, this change would fix the fail.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Oct 1, 2024
Copy link

stackblitz bot commented Oct 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red enabled auto-merge (squash) October 1, 2024 03:49
Copy link
Collaborator

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I confirmed the fix locally.

@sapphi-red sapphi-red merged commit 8f82730 into vitejs:main Oct 1, 2024
12 checks passed
@sapphi-red sapphi-red deleted the chore/fix-test-server-worker-runner branch October 1, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants