Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more explicit defineComponent example #3075

Merged
merged 1 commit into from
May 8, 2021
Merged

docs: more explicit defineComponent example #3075

merged 1 commit into from
May 8, 2021

Conversation

uptownhr
Copy link
Contributor

@uptownhr uptownhr commented Apr 21, 2021

For people like me that are not familiar with defineComponent, I ran into an issue using this plugin and HMR not working. It would have been great if the docs were something I could copy and paste and still work.

#3002 (comment)

  • Documentation update

For people like me that are not familiar with defineComponent, I ran into an issue using this plugin and HMR not working. #3002 (comment)
@Shinigami92 Shinigami92 added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Apr 21, 2021
@antfu antfu changed the title Adding a more explicit defineComponent example docs: more explicit defineComponent example May 8, 2021
@antfu antfu merged commit d555dd6 into vitejs:main May 8, 2021
@uptownhr uptownhr deleted the patch-1 branch May 16, 2021 09:47
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants