fix: resolve nested dependencies (#3254)

[Yelmor]

Description

Current vite(2.3.7) cannot resolve nested package on dev mode.

If a project has dependencies like this:

.
└── node_modules
    ├── [email protected]
    │   └── package.json
    └── [email protected]
        ├── node_modules
        │   └── [email protected]
        │       └── package.json
        └── package.json

Only [email protected] will be load at runtime, and package-b actually import [email protected] instead of [email protected] .

Additional context

There was two fixes before.

#3003 uses resolveDir as module location, which worked. But it mistakenly use flatId as module path, causing scoped package cannot be resolved.

#3053 changed flatId to qualified[flatId], which fixed scoped package problem, but again the nested pacakge problem occurs.

I'm not sure if this commit finnally fix the problem, or causing further errors, it passed the tests anyway.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[Yelmor]

Awesome! So this fix can be merged now?

[patak-dev]

@Yelmor would you check #4005? Looks like react-query devtools are breaking after this PR. If it is not something easy to solve, maybe we should revert this one for 2.4.0 and keep iterating on it

[Yelmor]

@Yelmor would you check #4005? Looks like react-query devtools are breaking after this PR. If it is not something easy to solve, maybe we should revert this one for 2.4.0 and keep iterating on it

I checked the demo and find out that the dependency react-query should resolve to /node_modules/react-query/es/index.js but the nodejs require.resolve resolves it to /node_modules/react-query/lib/index.js.

And I checked the code, vite has it's own way to resolve deps, it creates PluginContainer and uses plugins to do that.

So using single require.resolve is not the correct way to fix the problem.

It seems not easy to extract a independent funciton to resolve sub-deps path from deps directory in vite's way.

You may revert this fix for current release, but we still need to find a way to fix the problem.

[patak-dev]

Thanks for looking into this. It seems there are two other related issues #4014 and #4012. I think we should revert and keep working on a solution

[dickeylth]

Thanks for looking into this. It seems there are two other related issues #4014 and #4012. I think we should revert and keep working on a solution

The issue still exists [email protected], and #4014 and #4012 are closed, is there anyone still working on the issue?

[patak-dev]

@dickeylth would you create a new issue against the latest version of vite ([email protected]) so we can properly track the bug report?