Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when importing component with no script tag #46

Merged
merged 1 commit into from
May 4, 2020
Merged

fix: crash when importing component with no script tag #46

merged 1 commit into from
May 4, 2020

Conversation

mathieumure
Copy link
Contributor

@mathieumure mathieumure commented May 4, 2020 •
edited
Loading

Fix a crash when importing a vue component with no script tag. It also fixes the tests.

This was caused by a parsing error:

const __script = {}import { updateStyle } from "/@hmr"

which is not JS valid. So I add the following to be

const __script = {}
import { updateStyle } from "/@hmr"

@yyx990803 yyx990803 merged commit 586626f into vitejs:master May 4, 2020
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Nov 9, 2024
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
0a91555
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Nov 11, 2024
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
a9e70bc
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Nov 13, 2024
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
8d2cc03
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Nov 15, 2024
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
10bcd24
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Nov 28, 2024
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
e4b523d
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Nov 30, 2024
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
83e64f0
hi-ogawa pushed a commit to hi-ogawa/vite that referenced this pull request Jan 6, 2025
@IWANABETHATGUY @sapphi-red
feat: native build plugins (vitejs#45) (vitejs#46)
8b2de2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieumure @yyx990803