Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
process.env.NODE_ENV
too for esbuilddefine
object. Similar to the define plugin:vite/packages/vite/src/node/plugins/define.ts
Line 15 in eb57627
Additional context
Found this issue at https://github.com/vitejs/vite/pull/7246/files#r846999746
While optimizing is for dev only, if we set
mode
to something else, it could affect defineprocess.env.NODE_ENV
which doesn't seem right to me.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).