Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add team page #8720

Merged
merged 18 commits into from
Jul 11, 2022
Merged

docs: add team page #8720

merged 18 commits into from
Jul 11, 2022

Conversation

kiaking
Copy link
Contributor

@kiaking kiaking commented Jun 22, 2022

Description

This PR updates VitePress and adds Team Page 👫

Screen Shot 2022-06-22 at 20 08 14

Please Review

01. Nav menu items have changed

We can't add extra nav menu "Team", because adding more item will crush with search box on 768px breakpoint. We must introduce another menu group.

I went with changing Links -> Resources and added Team menu there. Maybe it should be named Community?

Another idea might be to group "Guide", "Config", and "Plugins" to Docs. What do you think is the best?

02. Please callout to team members to verify their profile

I've added info of all team members based on their GitHub account. Though I might have invented some text my self 😅 Please review each members profile.

You could remove desc property and design will still look good. I like the desc because it kinda gives me more close feeling for each members, but if it's hard to come up with something, I think it's OK to remove it.

Especially, if we have to remove few members "desc", I think we should remove from all of members for consistency. And it feels like those with no desc is left behind in the team.

03. Please check page title and lead texts

Those are heavily inspired by Vue website. Please adjust them to fit best for Vite team 👍


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jun 22, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit ea41953
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62c6d84c1b4077000989b780
😎 Deploy Preview https://deploy-preview-8720--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

Please callout to team members to verify their profile

I'm going to DM them to avoid a lot of messages here so they can comment in the PR in case they would like something to be changed

docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Jun 22, 2022
Co-authored-by: Shinigami <[email protected]>
docs/_data/team.js Outdated Show resolved Hide resolved
patak-dev
patak-dev previously approved these changes Jun 23, 2022
sapphi-red
sapphi-red previously approved these changes Jun 24, 2022
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
@bluwy bluwy dismissed stale reviews from sapphi-red and patak-dev via 00816b8 July 5, 2022 14:05
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
docs/_data/team.js Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested a review from ygj6 July 7, 2022 06:21
docs/_data/team.js Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Jul 7, 2022
docs/_data/team.js Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Jul 7, 2022
docs/_data/team.js Outdated Show resolved Hide resolved
@userquin
Copy link
Contributor

userquin commented Jul 7, 2022

@kiaking suggestion: add the current version for v3 and v2 on the nav link

@patak-dev patak-dev merged commit 519f7de into vitejs:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants