-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add team page #8720
Merged
Merged
docs: add team page #8720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm going to DM them to avoid a lot of messages here so they can comment in the PR in case they would like something to be changed |
patak-dev
reviewed
Jun 22, 2022
patak-dev
reviewed
Jun 22, 2022
bluwy
reviewed
Jun 22, 2022
bluwy
reviewed
Jun 22, 2022
Shinigami92
reviewed
Jun 22, 2022
sapphi-red
reviewed
Jun 22, 2022
Co-authored-by: Shinigami <[email protected]>
patak-dev
reviewed
Jun 23, 2022
patak-dev
previously approved these changes
Jun 23, 2022
sapphi-red
previously approved these changes
Jun 24, 2022
Shinigami92
reviewed
Jun 24, 2022
bluwy
reviewed
Jun 24, 2022
aleclarson
reviewed
Jul 7, 2022
aleclarson
reviewed
Jul 7, 2022
aleclarson
reviewed
Jul 7, 2022
Co-authored-by: Shinigami <[email protected]>
ygj6
reviewed
Jul 7, 2022
Shinigami92
previously approved these changes
Jul 7, 2022
sapphi-red
reviewed
Jul 7, 2022
Shinigami92
previously approved these changes
Jul 7, 2022
bluwy
reviewed
Jul 7, 2022
bluwy
approved these changes
Jul 7, 2022
@kiaking suggestion: add the current version for v3 and v2 on the nav link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates VitePress and adds Team Page 👫
Please Review
01. Nav menu items have changed
We can't add extra nav menu "Team", because adding more item will crush with search box on 768px breakpoint. We must introduce another menu group.
I went with changing
Links
->Resources
and addedTeam
menu there. Maybe it should be namedCommunity
?Another idea might be to group "Guide", "Config", and "Plugins" to
Docs
. What do you think is the best?02. Please callout to team members to verify their profile
I've added info of all team members based on their GitHub account. Though I might have invented some text my self 😅 Please review each members profile.
You could remove
desc
property and design will still look good. I like thedesc
because it kinda gives me more close feeling for each members, but if it's hard to come up with something, I think it's OK to remove it.Especially, if we have to remove few members "desc", I think we should remove from all of members for consistency. And it feels like those with no
desc
is left behind in the team.03. Please check page title and lead texts
Those are heavily inspired by Vue website. Please adjust them to fit best for Vite team 👍
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).