fix: url() with variable or relative path in sass/scss is broken (fixes #7651) #8765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-docs-main canceled.
|
frankyeyq
changed the title
frankyeyq
changed the title
sapphi-red
reviewed
Jun 25, 2022
| @@ -1478,7 +1488,7 @@ async function rebaseUrls( | |||
| } | |||
|
|
|||
| if (hasUrls) { | |||
| rebased = await rewriteCssUrls(rebased || content, rebaseFn) | |||
| rebased = await rewriteCssUrls(rebased || content, rebaseFn, file) | |||
There was a problem hiding this comment.
Maybe we could pass variablePrefix($, @) from rebaseUrls is called instead of file name? It will remove many conditions.
| (inLess && rawUrl.startsWith('@')) || | ||
| ((inSass || inScss) && rawUrl.startsWith('$')) | ||
| ) { | ||
| return `url('${rawUrl}')` |
There was a problem hiding this comment.
Suggested change
| return `url('${rawUrl}')` | |
| return `url(${rawUrl})` |
I think rawUrl include quotes if needed.
sapphi-red
added
feat: css
p3-minor-bug
sapphi-red
changed the title
|
Any news on this PR? |
|
Is there anything I can do to help get this PR merged? I'd love to migrate our projects over from Webpack to Vite, but this is a real blocker for us. |
|
We need tests for this. Feel free to send another PR that supersedes this with tests! |
|
Any news? |
|
I tried implementing this into a new PR with tests but a load of other seemingly unrelated tests started failing because of it. This is out of my area of expertise so not something I'm going to be able to help with unfortunately. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #7651
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).