fix(hmr): infer hmr hostname on client #980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github/VS Codespaces don't forward WebSocket requests so the HMR hostname must be manually configured in vite config like so:
New codespaces get a different UUID so need to be reconfigured each time. This PR infers hostname on the client rather than server by default so codespace users only need to specify the WS port (443) in vite config.
This is the same behaviour as prior to bec6b3c. Use cases such as #918 can now be addressed by defining a hostname in the config as above (introduced subsequently with b753478); these users are less inconvenienced as their backend URL is unlikely to change.