feat: disable private http by default

vitelabs · Nov 30, 2022 · 3c1cbfc · 3c1cbfc
1 parent b493ef3
commit 3c1cbfc
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/common/default_params.go b/common/default_params.go
@@ -10,7 +10,6 @@ import (
 const (
 	DefaultHTTPHost = "localhost" // Default host interface for the HTTP RPC server
 	DefaultHTTPPort = 48132       // Default TCP port for the HTTP RPC server
-	DefaultPrivateHTTPPort = 48133// Default TCP port for the private HTTP RPC server
 	DefaultWSHost   = "localhost" // Default host interface for the websocket RPC server
 	DefaultWSPort   = 31420       // Default TCP port for the websocket RPC server
 	DefaultP2PPort  = 8483

diff --git a/node/config/defaults.go b/node/config/defaults.go
@@ -16,7 +16,6 @@ var DefaultNodeConfig = Config{
 	KeyStoreDir: DefaultDataDir(),
 	HttpPort:    common.DefaultHTTPPort,
 	WSPort:      common.DefaultWSPort,
-	PrivateHttpPort:    common.DefaultPrivateHTTPPort,
 
 	LogLevel:      "info",
 	HTTPCors:      []string{"*"},

diff --git a/rpc/endpoints.go b/rpc/endpoints.go
@@ -63,7 +63,7 @@ func StartHTTPEndpoint(endpoint string, privateEndpoint string, apis []API, modu
 
 	go NewHTTPServer(cors, vhosts, timeouts, handler).Serve(listener)
 
-	if privateBind {
+	if privateBind && len(privateEndpoint) > 0 {
 		if privateListener, err = net.Listen("tcp", privateEndpoint); err != nil {
 			return nil, nil, nil, nil, err
 		}