Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all the Go dependencies #11741

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Update all the Go dependencies #11741

merged 2 commits into from
Nov 21, 2022

Conversation

dbussink
Copy link
Contributor

Description

This seems to work for the basics just fine, so let's have CI take a run at this as well to update these.

Only one small update to the Azure blob storage handling seems needed so far.

Related Issue(s)

Some more critical changes have been separate updated already in for example #11694

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 16, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@dbussink dbussink added Component: Build/CI Type: Internal Cleanup dependencies Pull requests that update a dependency file labels Nov 16, 2022
@deepthi
Copy link
Member

deepthi commented Nov 16, 2022

I think this is a good idea. We can review after the tests are fixed (since they look like they might need actual code changes to pass).

@deepthi deepthi mentioned this pull request Nov 16, 2022
Closed
3 tasks
@dbussink
Update all the Go dependencies
ab6eda3 
This seems to work for the basics just fine, so let's have CI take a run
at this as well to update these.

Only one small update to the Azure blob storage handling seems needed so
far.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/test-updating-all-go-deps branch from 545f73c to a5a19d3 Compare November 17, 2022 12:31
@dbussink
Copy link
Contributor Author

I think this is a good idea. We can review after the tests are fixed (since they look like they might need actual code changes to pass).

@deepthi Yeah, the main issue is that we have many places that end up using reflect.DeepEqual with protobufs which is not supported and only kinda sometimes work. I've updated a lot of cases here but we still have many more of those cases that could break at any change in the protobuf package.

@dbussink
Use correct proto comparisons
5597975 
We're using `reflect.DeepEqual` or `testify` helpers that essentially
use that in a number of places are comparing protobufs. This is not
supported though, protobufs are not comparable with `reflect.DeepEqual`.

This is exposed because of the tiny patch bump of protobuf which changes
some internal optimization of how it initializes protobufs that breaks
all this.

Instead, move to the appropriate helpers here.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/test-updating-all-go-deps branch from a5a19d3 to 5597975 Compare November 17, 2022 13:33
@dbussink
Copy link
Contributor Author

This is now ready for review. The issue in the vtgate_queries is unrelated to the changes here, but @harshit-gangal is looking at that separately.

@dbussink dbussink marked this pull request as ready for review November 17, 2022 14:30
systay
systay approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! ❤️

harshit-gangal
harshit-gangal reviewed Nov 18, 2022
View reviewed changes
go/sqltypes/result.go
Comment on lines -93 to 98
InsertID: result.InsertID,
RowsAffected: result.RowsAffected,
Info: result.Info,
InsertID: result.InsertID,
SessionStateChanges: result.SessionStateChanges,
StatusFlags: result.StatusFlags,
Info: result.Info,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like unrelated changes for the PR StatusFlags: result.StatusFlags

@frouioui frouioui merged commit c67c790 into vitessio:main Nov 21, 2022
@frouioui frouioui deleted the dbussink/test-updating-all-go-deps branch November 21, 2022 07:00
@dbussink dbussink mentioned this pull request Nov 21, 2022
Merged
3 tasks
@deepthi deepthi mentioned this pull request Dec 11, 2022
Closed
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Apr 8, 2024
@dbussink @timvaillancourt
Update all the Go dependencies (vitessio#11741)
18faa1e 
* Update all the Go dependencies

This seems to work for the basics just fine, so let's have CI take a run
at this as well to update these.

Only one small update to the Azure blob storage handling seems needed so
far.

Signed-off-by: Dirkjan Bussink <[email protected]>

* Use correct proto comparisons

We're using `reflect.DeepEqual` or `testify` helpers that essentially
use that in a number of places are comparing protobufs. This is not
supported though, protobufs are not comparable with `reflect.DeepEqual`.

This is exposed because of the tiny patch bump of protobuf which changes
some internal optimization of how it initializes protobufs that breaks
all this.

Instead, move to the appropriate helpers here.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Apr 9, 2024
@timvaillancourt
Revert "Update all the Go dependencies (vitessio#11741)"
ebe2d5b 
This reverts commit 18faa1e.
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 22, 2024
@timvaillancourt @GuptaManan100 @dbussink
slack-vitess-r15.0.5: add slack_cross_cell custom durability poli…
a912583 
…cy (#266)

* `slack-vitess-r15.0.5`: add `slack_cross_cell` custom durability policy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy again

Signed-off-by: Tim Vaillancourt <[email protected]>

* Use tag

Signed-off-by: Tim Vaillancourt <[email protected]>

* use v0.15.1

Signed-off-by: Tim Vaillancourt <[email protected]>

* update shim

Signed-off-by: Tim Vaillancourt <[email protected]>

* Make `Durabler` interface methods public (vitessio#15548)

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>

* Update `slack_cross_cell` shim

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy again

Signed-off-by: Tim Vaillancourt <[email protected]>

* Allow private go module from vitess-additions repo

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix typo

Signed-off-by: Tim Vaillancourt <[email protected]>

* Missing non-template update

Signed-off-by: Tim Vaillancourt <[email protected]>

* Missing non-template update

Signed-off-by: Tim Vaillancourt <[email protected]>

* Missing non-template update, pt 3

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix docker tests

Signed-off-by: Tim Vaillancourt <[email protected]>

* make proto

Signed-off-by: Tim Vaillancourt <[email protected]>

* fix upgrade/downgrade tests

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update all the Go dependencies (vitessio#11741)

* Update all the Go dependencies

This seems to work for the basics just fine, so let's have CI take a run
at this as well to update these.

Only one small update to the Azure blob storage handling seems needed so
far.

Signed-off-by: Dirkjan Bussink <[email protected]>

* Use correct proto comparisons

We're using `reflect.DeepEqual` or `testify` helpers that essentially
use that in a number of places are comparing protobufs. This is not
supported though, protobufs are not comparable with `reflect.DeepEqual`.

This is exposed because of the tiny patch bump of protobuf which changes
some internal optimization of how it initializes protobufs that breaks
all this.

Instead, move to the appropriate helpers here.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

* Resolve signature mismatch

Signed-off-by: Tim Vaillancourt <[email protected]>

* revert protobuf version

Signed-off-by: Tim Vaillancourt <[email protected]>

* revert protobuf version, pt 2

Signed-off-by: Tim Vaillancourt <[email protected]>

* Revert "Update all the Go dependencies (vitessio#11741)"

This reverts commit 18faa1e.

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 29, 2024
@timvaillancourt
steal statsd fix from vitessio#11741
7373227 
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 30, 2024
@timvaillancourt
slack-15.0: basic go.mod updates (#382)
b2e4e0c 
* `slack-15.0`: basic go.mod updates

Signed-off-by: Tim Vaillancourt <[email protected]>

* fix signature in `go/vt/mysqlctl/azblobbackupstorage/azblob.go`

Signed-off-by: Tim Vaillancourt <[email protected]>

* update expected error for new mysql driver

Signed-off-by: Tim Vaillancourt <[email protected]>

* more go.mod updates

Signed-off-by: Tim Vaillancourt <[email protected]>

* steal statsd fix from vitessio#11741

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* update flag e2e tests

Signed-off-by: Tim Vaillancourt <[email protected]>

* update flag e2e tests

Signed-off-by: Tim Vaillancourt <[email protected]>

* update flag e2e tests

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@systay systay systay approved these changes

@mattlord mattlord mattlord approved these changes

@ajm188 ajm188 ajm188 approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@notfelineit notfelineit notfelineit approved these changes

@frouioui frouioui frouioui approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani

@vmg vmg Awaiting requested review from vmg vmg is a code owner

Assignees
No one assigned
Labels
Component: Build/CI dependencies Pull requests that update a dependency file Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dbussink @deepthi @systay @mattlord @ajm188 @harshit-gangal @notfelineit @frouioui