Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Use Debian Bullseye in Bootstrap #13757

Merged
merged 15 commits into from
Sep 6, 2023
Merged

[release-17.0] Use Debian Bullseye in Bootstrap #13757

merged 15 commits into from
Sep 6, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Aug 9, 2023 •
edited
Loading

Description

This PR is a follow-up of #13664. We are bumping the bootstrap images to bullseye in order to keep up with the Golang upgrades. We are not changing the packages we install, we keep the buster packages. Except on percona images, where bullseye packages had to be installed for compatibility.

I have tested the entire operator example back and forth with different MySQL version and was able to complete it each time.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@frouioui
Upgrade to bootstrap version 18.1
0f7f235 
Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 9, 2023
@github-actions github-actions bot added this to the v17.0.2 milestone Aug 9, 2023
@frouioui frouioui modified the milestones: v17.0.2, v17.0.3 Aug 25, 2023
@frouioui
spread percona57 apt-get instruction onto different lines
8a49b08 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
run percona80 boostrap using bullseye packages
c03780a 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
debug: build and push to frouioui DockerHub account
b686348 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
debug: build and push lite images to frouioui DockerHub account
4342cf0 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
debug: use frouioui bootstrap image as base for lite images
8f1db11 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
use bullseye package for percona
88bf2f4 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
revert unwanted changes to lite images
9774cf2 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the bp-13664-to-17 branch 3 times, most recently from 8a2c529 to b45f81a Compare August 28, 2023 23:02
@frouioui
install zstd in ubi7.mysql80
54b0de7 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
debug: use frouioui images in the examples
1ba3c03 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
remove debugging
86cad59 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as ready for review August 29, 2023 16:36
@frouioui frouioui added Type: Internal Cleanup Component: Build/CI Backport to: release-16.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Aug 29, 2023
GuptaManan100
GuptaManan100 reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from buster to bullseye doesn't affect the functionality of the docker images, right?

docker/bootstrap/Dockerfile.percona57 Show resolved Hide resolved
@frouioui
Copy link
Member Author

Changing from buster to bullseye doesn't affect the functionality of the docker images, right?

After running some tests it did not.

GuptaManan100
GuptaManan100 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since manual testing has been done 👍

@frouioui frouioui merged commit 3afc07a into vitessio:release-17.0 Sep 6, 2023
@frouioui frouioui deleted the bp-13664-to-17 branch September 6, 2023 13:16
@vitess-bot vitess-bot bot mentioned this pull request Sep 6, 2023
Merged
frouioui added a commit that referenced this pull request Sep 7, 2023
@vitess-bot @frouioui
[release-16.0] Use Debian Bullseye in Bootstrap (#13757) (#13921)
7012754 
Co-authored-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@dbussink dbussink Awaiting requested review from dbussink

Assignees
No one assigned
Labels
Component: Build/CI Type: Internal Cleanup
Projects
None yet
Milestone
v17.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @vmg @GuptaManan100