Code

Add leak checking for vtgate tests#13835

Code

Merged

dbussink merged 17 commits intovitessio:mainvitessio/vitess:mainfrom planetscale:dbussink/refactor-vtgate-testsplanetscale/vitess:dbussink/refactor-vtgate-testsCopy head branch name to clipboardAug 28, 2023

+4,588-3,236

Commits

Commits on Aug 28, 2023

• Add leak checking for vtgate tests

  Show description for 33dd285
  dbussink

  committed
  33dd285

  Copy full SHA for 33dd285

• Remove global primary session

  Show description for 0ad34ce
  dbussink

  committed
  0ad34ce

  Copy full SHA for 0ad34ce

• Pass in context for all topos

  Show description for 47b0e3a
  dbussink

  committed
  47b0e3a

  Copy full SHA for 47b0e3a

• vtgate: Remove globals

  Show description for f34e71f
  dbussink

  committed
  f34e71f

  Copy full SHA for f34e71f

• Fix additional tests and cleanup

  Show description for 7798273
  dbussink

  committed
  7798273

  Copy full SHA for 7798273

• Plug more leaks

  Show description for 48b36dc
  dbussink

  committed
  48b36dc

  Copy full SHA for 48b36dc

• Cleanup tests

  Show description for 478a4df
  dbussink

  committed
  478a4df

  Copy full SHA for 478a4df

• Plug some tabletmanager/vreplication unit test leaks: stats and rowstreamer

  Show description for 864a528
  

  rohit-nayak-ps

  authored and

  dbussink

  committed
  864a528

  Copy full SHA for 864a528

• Added utility GetLeaks() to log leaks esp. in TestMain() and related refactor

  Show description for cfe7a28
  

  rohit-nayak-ps

  authored and

  dbussink

  committed
  cfe7a28

  Copy full SHA for cfe7a28

• Duh, defer stats.Stop()

  Show description for be9e89f
  

  rohit-nayak-ps

  authored and

  dbussink

  committed
  be9e89f

  Copy full SHA for be9e89f

• License

  Show description for b81debc
  

  rohit-nayak-ps

  authored and

  dbussink

  committed
  b81debc

  Copy full SHA for b81debc

• Change plain utils.EnsureNoLeaks(0 to defers

  Show description for 649a7a4
  

  rohit-nayak-ps

  authored and

  dbussink

  committed
  649a7a4

  Copy full SHA for 649a7a4

• Found testing.tRunner.func1 for TestDeleteShards, for now adding to acceptable goleaks

  Show description for 959cff2
  

  rohit-nayak-ps

  authored and

  dbussink

  committed
  959cff2

  Copy full SHA for 959cff2

• vttest: use testing.T.Cleanup

  Show description for d52a492
  

  vmg

  authored and

  dbussink

  committed
  d52a492

  Copy full SHA for d52a492

• utils: documentat the two new noleak APIs

  Show description for fbcaba4
  

  vmg

  authored and

  dbussink

  committed
  fbcaba4

  Copy full SHA for fbcaba4

• Fix rebased tests

  Show description for 488a155
  dbussink

  committed
  488a155

  Copy full SHA for 488a155

• Allow additional throttler for leak check

  Show description for 27ab83e
  dbussink

  committed
  27ab83e

  Copy full SHA for 27ab83e