[vtadmin-web] Remove craco dependency

[doeg]

Signed-off-by: Sara Bee [email protected]

Description

This PR removes the craco dependency. Arguably the best kind of dependency "upgrade". 😎

I noticed this when running npm update:

🍕~/workspace/vitess/web/vtadmin $ npm update
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react-scripts
npm ERR!   react-scripts@"^5.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react-scripts@"^4.0.0" from @craco/[email protected]
npm ERR! node_modules/@craco/craco
npm ERR!   @craco/craco@"^6.4.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/sarabee/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/sarabee/.npm/_logs/2022-01-28T20_05_21_769Z-debug.log

craco was added in #9215 in order to install [email protected]. Thanks to @notfelineit by way of #9493, we're now using [email protected] which supports tailwindcss out of the box.

This means we no longer need craco, and indeed the [email protected] docs no longer mention it.

We still need to upgrade to [email protected]; as of this PR, we're still on npm:@tailwindcss/postcss7-compat@^2.2.17 (per the tailwindcss@v2 guide), which incidentally breaks npm outdated (TIL). I'll do the tailwindcss upgrade in a separate PR to keep things tidy.

I tested this change by running all of the scripts in package.json that previously relied on craco. I made sure to also test changes to the tailwind.config.js and base CSS files (to force a full tailwind rebuild). Everything runs + builds fine.

Related Issue(s)

• [vtadmin-web] Add tailwindcss #9215 originally added tailwindcss@2 + the craco dependency
• [VTAdmin] Update react-scripts, postcss #9493 updated our react-scripts dependency to v5.x, obviating the need for craco.

Checklist

• Should this PR be backported? No
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

Not strictly necessary, but if you have an existing node_modules folder, I'd recommend doing npm install (or a full rm -rf node_modules && npm install, if you like). This is mostly relevant for developers rather than operators, as the vtadmin-web targets in the Makefile already do an npm install.

[notfelineit]

Ah heck yeah! This is so nice!

[doeg]

@notfelineit I found one more craco-related thing we can delete (yay). Would you mind reviewing this one more time?