-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update to the correct test #3643
Conversation
Run & review this pull request in StackBlitz Codeflow. |
e2f90d2
to
ea1494b
Compare
9e4101c
to
76c8b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also increase the chaiConfig.truncateThreshold
of test/reporters/vitest.config.ts
as the current error messages do not show what the actual output was:
AssertionError: expected '? Input filename pattern › b✔ Input f…' to not include 'b1 test'
Example:
vitest/test/fails/vite.config.ts
Lines 6 to 8 in fbb56ad
chaiConfig: { | |
truncateThreshold: 9999, | |
}, |
Wow, Thank you, I regret learning about it too late. |
Thank you! Let's hope this is enough |
Related PR: #3266
I think I know what causes Ci to always fail. default reporter also prints all the test logs when it runs. However, as the test task is updated, some tests will no longer be printed out.
So in
runVitestCli
, the run logs of all tests will be stored in stdout, sob1 test
may exist due to different machines and different run times, etc. Now I've added✓
to them to make sure they are not included in the final test log.And this change is consistent with the intent of the original test.