Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added jest expect support #66

Merged
merged 15 commits into from
Dec 12, 2021
Merged

feat: added jest expect support #66

merged 15 commits into from
Dec 12, 2021

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Dec 11, 2021

with this libraries (like #60) can use vitest with jest's extend

@sheremet-va sheremet-va requested a review from antfu December 11, 2021 07:37
package.json Outdated Show resolved Hide resolved
@sheremet-va
Copy link
Member Author

I've removed expect, but it didn't change lockfile much, because jest-snapshot uses it 😞

They also are using a lot of jest packages!

  expect: 27.4.2
  jest-diff: 27.4.2
  jest-get-type: 27.4.0
  jest-haste-map: 27.4.2
  jest-matcher-utils: 27.4.2
  jest-message-util: 27.4.2
  jest-resolve: 27.4.2
  jest-util: 27.4.2

@sheremet-va sheremet-va requested a review from antfu December 11, 2021 17:47
@antfu
Copy link
Member

antfu commented Dec 11, 2021

Then how about we just use expect instead of chai? 😅

As discussed, we decided to not depend on jest-* for better optimization and integration, while trying to make it compatible for users to migrate.

@sheremet-va
Copy link
Member Author

I need a review ⭐

@antfu
Copy link
Member

antfu commented Dec 12, 2021

Looks awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants