-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resolved project names to the reporter API #7213
Changes from 1 commit
2118da5
1f55e69
fb1b3a0
0d72e96
10b1744
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -328,6 +328,13 @@ export class Vitest { | |
return this.coreWorkspaceProject | ||
} | ||
|
||
/** | ||
* Get project names. | ||
*/ | ||
public getResolvedProjectNames(): string[] { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this should be a public API. You can access There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh thx There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need to access it from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm going to provide a callback to resolve the project names. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. argg, it is a reporter not a plugin, we'll need to expose it in the public API There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. internal fields should be visible in all internal packages, and ui is an internal package. the field is not private |
||
return this.resolvedProjects.map(p => p.name) | ||
} | ||
|
||
/** | ||
* @deprecated use Reported Task API instead | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will require some changes when exposing the data for the filter selector, should be fixed in #7201 once merged