Add number formatting #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitiral
approved these changes
Dec 13, 2017
| 'x' | 'X' => self.write_str("0x").unwrap(), | ||
| _ => { | ||
| let mut msg = String::new(); | ||
| write!(msg, "alternate ('#') cannot be used with type {:?}", ty).unwrap(); |
There was a problem hiding this comment.
when I first wrote this lib I didn't know about format!(). Please use that instead here. You can even get rid of msg variable alltogether.
There was a problem hiding this comment.
whoops, I'll handle it in a separate commit... maybe (who really cares, haha).
Thanks for the PR!
|
|
||
| pub use types::{Result, FmtError, Alignment, Sign}; | ||
| pub use fmtstr::strfmt_map; | ||
| pub use formatter::Formatter; | ||
|
|
||
| // u128 & i128 unstable (see https://github.com/rust-lang/rust/issues/35118) | ||
| fmtint!(u8 i8 u16 i16 u32 i32 u64 i64 usize isize); |
There was a problem hiding this comment.
whoa! I didn't know this was possible, I thought they would have to each be their own line. Good work!
|
Looks good, from travis run: |
|
No problem 👍 |
|
I just publised |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #13.
I ended up splitting it into two macros, one for integers and one for floats. I also spilt the tests into three macros for unsigned and signed integers, and floats.
Let me know if you have any comments 👍