split Run into Run and Read to ensure logs are captured #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this broke when I got rid of unhyphenation
previously this relied on w != io.Discard to determine whether to capture logs, which feels way overloaded and caused logs to not be captured over gRPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Booklit tests against Bass Loop I noticed test output wasn't being forwarded. Turned out this was happening because the GRPC stack lost the notion of
io.Discardbeing passed toRunwhich is how it previously knew to just send output to the progress UI. Splitting this method in twain makes it much more explicit.