reap zombies #234
Merged
reap zombies #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shim is the init, not the command. but we can just have the shim reap zombies!
rather than forcing folks to configure a dumb-init entrypoint, we'll just have the shim handle reaping zombies, since it's already there, and it's pretty handy to not have to ever think about this sidebar: we're getting into "how i learned to stop worrying and love the shim" territory. it's a bit of a pain to have to maintain, but it sure grants a lot of flexibility!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
shimexecutable (which runs as the init process for every thunk) to additionally reap child processes spawned by the thunk that would otherwise become zombies upon exiting.Concretely this prevents accumulation of zombie
dnsmasqprocesses when running Buildkit as a service for the tests. But it should help with any long-running service that needs to spawn processes that daemonize and then exit. Or an irresponsible parent that doesn't look after its children.