Read private properties from parent class #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys!
This PR fixes a little issue when you are working with a inheritance.
If you have a parent with private properties that use the annotation of the StringGeneratorBundle (Generate) it is ignored because it only uses the child properties. It should consider also the properties of parent.
The inheritance in Doctrine entities is not common, but there are a little use cases where use the
Doctrine\ORM\Mapping\MappedSuperclassis absolutely needed and if you want maintain the properties private, before this patch, you couln't.I hope that it helps!