Bug fixes and improvements #1
Conversation
- return 100 when file is empty/completely skipped (was returning 1) - 100% coverage for parse-coverage.js - fix relative path calculation in github-comment.js
- new emojis in some cases - fix path calculation for links to files in folders - render main coverage link outside of pre tag - don't show unchanged folders in overview - add folder coverage under details - 100% coverage for format-coverage.js
Code Coverage
from Circle CI build 26
Project Coverage 59.89% 💛
src/ 59.89% 💛 Folder Coveragesrc/ 59.89% 💛 |
- don't show change stats if there is no prior coverage to compare to
|
Code Coverage
from Circle CI build 29
58.22% 💛 Folder Coveragesrc/ 58.22% 💛 |
- add dependency on istanbul-lib-report - compute common root when parsing coverage file - simplify link computation - more tests - render markdown instead of html where possible
|
Code Coverage ** 58.74% 💛 ** Folder Coveragesrc/ 0.00% ❌ src/coverage/ 100.00% ✅ |
|
**Code Coverage: 57.84% 💛 ** Folder Coveragesrc/ 0.00% ❌ src/coverage/ 100.00% ✅ |
|
Code Coverage: 67.73% 💛 Folder Coveragesrc/ 23.40% 💔 src/coverage/ 100.00% ✅
From Circle CI build 37 — generated by coverage-github-reporter |
|
Code Coverage: 67.49% 💛 Folder Coveragesrc/ 23.17% 💔 src/coverage/ 100.00% ✅
From Circle CI build 38 — generated by coverage-github-reporter |
|
Code Coverage: 67.45% 💛 +12.36% 😀 src/ 22.95% 💔 -32.13% 😡 bot.js 21.79% 💔 +21.79% 😀 curl.js 50.00% 💔 +50.00% 😀 github-comment.js 33.38% 💔 +33.38% 😀 src/coverage/ 100.00% ✅ Folder Coveragesrc/ 22.95% 💔 src/coverage/ 100.00% ✅
From Circle CI build 40 (compared to build 23 of |
|
Code Coverage: 68.32% 💛 +13.23% 😀 src/ 22.95% 💔 -32.13% 😡 bot.js 21.79% 💔 +21.79% 😀 curl.js 50.00% 💔 +50.00% 😀 github-comment.js 33.38% 💔 +33.38% 😀 src/coverage/ 100.00% ✅ Folder Coveragesrc/ 22.95% 💔 src/coverage/ 100.00% ✅
Circle CI build 42 (compared to build 23 of |
|
|
||
| const ALL_FILES_PATH = '*' | ||
|
|
||
| const ERROR_THRESHOLD = 50 |
There was a problem hiding this comment.
Do you think it would be useful to stat (and read if it exists) a .cgr/.coverage-github-reporter/etc file containing overrides for these values? Maybe this is a 2.0 feature? The consts would be defaults if the config doesn't exist in that case.
|
|
||
| const getEmoji = (percent) => { | ||
| if (percent === 0) { | ||
| return '❌' |
There was a problem hiding this comment.
I suppose these could be customizable too in a .settings file in home, if that feature is added.
parse coverage:
format coverage: