Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh button on main feed page #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add refresh button on main feed page #53

wants to merge 2 commits into from

Conversation

snowkat
Copy link
Collaborator

@snowkat snowkat commented Oct 11, 2024

This creates an interval on the first page of a feed that checks for new posts, and provides a way to refresh the feed if it detects new posts.

Currently I have it hardcoded to 60s, but my hope is this can be configured in an eventual app settings.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-desert-07632091e-53.westus2.5.azurestaticapps.net

@vivlim
Copy link
Owner

vivlim commented Oct 11, 2024

One thing I want to double-check before merging is how attention-getting it is, since some users might not want that. Taking a look now

@vivlim
Copy link
Owner

vivlim commented Oct 11, 2024

I'm not sure how to make this show up. (i tried on my mastodon instance, snoot.tube)

do you have a screenshot?

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-desert-07632091e-53.westus2.5.azurestaticapps.net

@snowkat
Copy link
Collaborator Author

snowkat commented Oct 12, 2024

When you're on the main page of a profile or home feed (i.e. no ?after= query param), it'll check every 60sec. I just realized I mixed up type and variant, so this is what it's actually supposed to look like:

image

@vivlim
Copy link
Owner

vivlim commented Oct 12, 2024

That seems good to me.

When the button appears, does that cause the posts to shift down slightly? i think that could be a little annoying. I'm fine as is for now though.

@vivlim
Copy link
Owner

vivlim commented Oct 13, 2024

I pushed a rebase of this to refresher-rebased-multiaccount but I didn't really test it

@vivlim
Copy link
Owner

vivlim commented Nov 2, 2024

i'll need to reimplement this on the new feed engine / associated control, a lot is changed there (but it also hasn't fully landed as a replacement yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants