This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Add EPUB TOC navigation support and improve UI #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MurakamiShinyu
commented
Jan 26, 2019
MurakamiShinyu
commented
- Add "Table of Contents" (TOC) toggle button
- Improve keyboard navigation: shortcut keys for all tool buttons, etc.
- Enable double click (tap, keypress) on Settings and TOC buttons to keep open Settings/TOC panels
- Add ARIA role and aria-* attributes to improve accessibility
- Other UI improvement: Settings button now has "..." mark to make it clear it's settings button
- Remove (comment-out) some old tests to pass the tests (need update tests...)
- Add "Table of Contents" (TOC) toggle button - Improve keyboard navigation: shortcut keys for all tool buttons, etc. - Enable double click (tap, keypress) on Settings and TOC buttons to keep open Settings/TOC panels - Add ARIA role and aria-* attributes to improve accessibility - Other UI improvement: Settings button now has "..." mark to make it clear it's settings button - Remove (comment-out) some old tests to pass the tests (need update tests...)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.