Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CSS Logical Properties #443

Merged
merged 8 commits into from
Jul 17, 2018
Merged

Support CSS Logical Properties #443

merged 8 commits into from
Jul 17, 2018

Conversation

MurakamiShinyu
Copy link
Member

  • block-size, inline-size, min-block-size, min-inline-size, max-block-size, max-inline-size
  • margin-block-start, margin-block-end, margin-inline-start, margin-inline-end, margin-block, margin-inline
  • inset-block-start, inset-block-end, inset-inline-start, inset-inline-end, inset-block, inset-inline
  • padding-block-start, padding-block-end, padding-inline-start, padding-inline-end, padding-block, padding-inline
  • border-block-start-width, border-block-end-width, border-inline-start-width, border-inline-end-width, border-block-width, border-inline-width, border-block-start-style, border-block-end-style, border-inline-start-style, border-inline-end-style, border-block-style, border-inline-style, border-block-start-color, border-block-end-color, border-inline-start-color, border-inline-end-color, border-block-color, border-inline-color, border-block-start, border-block-end, border-inline-start, border-inline-end, border-block, border-inline

@MurakamiShinyu MurakamiShinyu merged commit f7f4c30 into master Jul 17, 2018
@MurakamiShinyu MurakamiShinyu mentioned this pull request Aug 22, 2019
Closed
MurakamiShinyu added a commit that referenced this pull request Nov 26, 2019
@MurakamiShinyu
Fix error on logical border shorthand properties
afa89b2 
**Problem:**
- "TypeError: Cannot read property 'visit' of undefined" occurs when logical border shorthand property is used.

e.g. `border-inline-start: 1px solid` causes this error.
when none of <border-width>, <border-style>, <border-color> is omitted this error does not happen.

This error happens because default value definition of logical border properties is missing in src/resources/validation.txt.
The problem existed since PR #443 "Support CSS Logical Properties".
MurakamiShinyu added a commit that referenced this pull request Nov 26, 2019
@MurakamiShinyu
Fix error on logical border shorthand properties
70bc732 
**Problem:**

"TypeError: Cannot read property 'visit' of undefined" occurs when logical border shorthand property is used.
e.g. `border-inline-start: 1px solid` causes this error.

When none of `<border-width>`, `<border-style>`, `<border-color>` is omitted,
e.g. `border-inline-start: 1px solid blue`, this error does not happen.

This error happens because default value definition of logical border properties is missing in src/resources/validation.txt.
The problem existed since PR #443 "Support CSS Logical Properties".
@MurakamiShinyu MurakamiShinyu mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MurakamiShinyu