Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment missing language dependencies (#3611) #3645

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

roflinn
Copy link
Member

@roflinn roflinn commented Feb 14, 2022

  • Uncomment missing language dependencies

  • Revert target home directory to generic name

Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.


VIVO GitHub issue: (please link to issue)

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

What's new?

An in-depth description of the changes made by this PR. Technical details and possible side effects. Include screenshots if appropriate.

Example:

  • Changes x feature to such that y
  • Added x
  • Removed y

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the pull request does what is intended.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository?
  • Could this change impact execution of existing code?
  • Large pull requests should be avoided. If this PR is large (more than 1,000 lines of codes), please provide short explanation why your contribution can't be decoupled in smaller PRs.

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

* Uncomment missing language dependencies

* Revert target home directory to generic name
@roflinn roflinn self-assigned this Feb 14, 2022
@roflinn
Copy link
Member Author

roflinn commented Feb 14, 2022

merge before 1.12.2 artifact create

@roflinn roflinn merged commit 0d66969 into main Feb 14, 2022
ghost pushed a commit that referenced this pull request Feb 23, 2023
* Uncomment missing language dependencies

* Revert target home directory to generic name

Co-authored-by: Ben <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants