Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent copying pom files to home directory #3689

Merged
merged 1 commit into from
May 21, 2022

Conversation

litvinovg
Copy link
Collaborator

@litvinovg litvinovg commented Apr 23, 2022

Changes artifact type from pom to tar.gz to prevent copying pom files ( vitro-languages-home-core-1.12.3-SNAPSHOT.pom
and vivo-languages-home-core-1.12.3-SNAPSHOT.pom ) to home directory.

How to test
Install VIVO from sources before applying, notice that files are added to home directory.
Clean home directory
Apply this PR
Install VIVO from sources, verify that files are not added to home directory

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@chenejac chenejac requested a review from gneissone May 11, 2022 11:03
Copy link
Member

@gneissone gneissone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds a-okay, no pom file in the home directory.

@chenejac chenejac merged commit cf016a7 into vivo-project:main May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants