Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing itextpdf dependency #3853

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

chenejac
Copy link
Contributor

VIVO GitHub issue: iTextPDF vulnerability

What does this pull request do?

removing dead code and iTextPDF dependency

What's new?

Remove a dependency from api/pom.xml, and remove PDFDocument class which is not used in VIVO at all.

How should this be tested?

Build and run VIVO, check logs and whether VIVO is running.

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

@chenejac chenejac requested review from brianjlowe, a user and milospp March 30, 2023 07:21
Copy link
Member

@brianjlowe brianjlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE found no references to the removed class. Builds and runs normally without it.

@litvinovg litvinovg self-requested a review April 20, 2023 13:58
Copy link
Collaborator

@litvinovg litvinovg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chenejac chenejac merged commit d548584 into vivo-project:main Apr 21, 2023
@chenejac chenejac removed request for a user and milospp April 27, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants