Disallow forms (with CAPTCHA) to bots #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milospp
approved these changes
Jan 23, 2024
ivanmrsulja
suggested changes
May 31, 2024
There was a problem hiding this comment.
One small change is requested as we changed this from kebbab-case to camel-case in the meantime.:
The other rules work as intended (I tested them using Merkle):
Co-authored-by: Ivan R. Mršulja <[email protected]>
ivanmrsulja
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
I have re-run all the tests using Merkle and now everything works as intended. Steps to reproduce the tests:
- Setup a publicly available Vitro server (I reccommend using a tool like NGROK)
- If the vivo does not run on the root URL and instead you have to go to
/vitroor something similar, you have to providerobots.txtmanually in the text editor - Choose the crawler of your choice from dropdown menu and try to fetch any of the disallowed domains
wwelling
approved these changes
Jun 13, 2024
milospp
pushed a commit
to milospp/Vitro
that referenced
this pull request
Dec 3, 2024
* Disallow forms (with CAPTCHA) to bots * Update webapp/src/main/webapp/robots.txt Co-authored-by: Ivan R. Mršulja <[email protected]> --------- Co-authored-by: Ivan R. Mršulja <[email protected]>
milospp
pushed a commit
to milospp/Vitro
that referenced
this pull request
Dec 8, 2024
* Disallow forms (with CAPTCHA) to bots * Update webapp/src/main/webapp/robots.txt Co-authored-by: Ivan R. Mršulja <[email protected]> --------- Co-authored-by: Ivan R. Mršulja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: 3935
Linked VIVO PR
What does this pull request do?
Disallow access to /contact and /forgot-password to bots (at least to bots which respect robots.txt)
What's new?
robots.txt is updated
How should this be tested?
Follow the instructions in Linked VIVO PR
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers