-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: animOptions support with Keyframes #25
Conversation
Switch from sub-slides to keyframes is basically done, need some cleanup to remove some unnecessary arrays and such. |
Subslide concept removed. |
@dyuri I merged main into it so it uses the correct Vizzu. |
I don't know how it's supposed to work, but since this player doesn't do much but calls the vizzu library, the issue might be there too. I've just removed the manual handling of sub-slides. |
@dyuri The problem seems to be that while vizzu-story calls vizzu.animate with the list of keyframes now, it still stores only the end chart: await this.vizzu.animate(animParams);
chartSteps.push(this.vizzu.store()); To be able to work correctly, it should store the whole animation: let animation = this.vizzu.animate(animParams);
let control = await animation.activated;
chartSteps.push(control.store());
await animation; |
tests are broken due to the API change :/ |
See comment on the issue: #26 (comment) |
Instead of manually handling "sub-slides", uses the new (currently unreleased) vizzu keyframes.
DO NOT RELEASE until vizzu keyframe support is released.
Closes #24.