Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug! after uploading, files are defective and larger #2

Closed
parajbs opened this issue Apr 26, 2023 · 4 comments
Closed

Bug! after uploading, files are defective and larger #2

parajbs opened this issue Apr 26, 2023 · 4 comments

Comments

@parajbs
Copy link

parajbs commented Apr 26, 2023

Hello @vlad20012,

i tested the docker version of your "vlad20012/ipfs-webdav".
The connection to the ipfs node worked, and I can also reach the webdav server.

I think it's a great project.

But there are problems, all uploaded files are defective afterwards.
They are on the ipfs node in the mfs, but the size of the files is no longer the same as the original size and even if I download the files via webdav or ipfs, the file size is no longer correct.
They are always bigger than the original.

I compared both files with diff, and it shows that the uploaded files have "0"s inserted in several places.

What's going on there?
I need your help because I don't know the programming language rust myself.

I think if it uploads the files cleanly and works, it's a super top ipfs project.

hopefully you can help.

@vlad20012
Copy link
Owner

Hi! Thank you for your report!
I've managed to reproduce it. It's weird I didn't notice it earlier 😅
I'll try to fix it today

vlad20012 added a commit that referenced this issue Apr 27, 2023
Fixes issue #2 (because of updating common-multipart-rfc7578 to version "0.6.0" that includes this commit
ferristseng/rust-multipart-rfc7578@6959435)
@vlad20012
Copy link
Owner

Fixed by 93d04d2 and released as 0.1.1.

A fun fact is that it was needed to just update dependencies to fix this issue (in other words, the issue has been fixed here - ferristseng/rust-multipart-rfc7578@6959435)

@parajbs
Copy link
Author

parajbs commented Apr 27, 2023

Hello @vlad20012,

Thank you for your quick reaction.
I tested the new version 0.1.1 and it works great.

I have a few questions:

  • Do you also know the Golang programming language?
    Since your project would also be interesting for a backend module from "rclone". rclone is written in golang.

  • maybe you are interested in writing an ipfs module for "rclone".
    I think it's super cool.
    maybe it is also possible to integrate rust into rclone? no idea.

your "ipfs-webdav" is definitely a great project.

@parajbs
Copy link
Author

parajbs commented Apr 27, 2023

I'm working with colleagues on the project "s5-dev/S5" where we built a "webdav store module" and testing all possible webdav providers and webdav software.

I will test your "ipfs-webdav" project there with the s5-node, and then add it to our list later, so that our other developers can also use their project for ipfs.

You can have a look at "s5-dev/S5" if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants