Fix action main to use packaged distributable #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the automated tests exactly replicates the way the action is used in consumer's workflows. The action must solely rely on the minimised distributable and not on dependencies from node_modules/ as the node_modules/ folder is not checked in.
Resolves #58 When @vercel/ncc was introduced, the action main should have been updated to `dist/index.js` which has all the dependencies packaged and minimised and thus doesn't rely on the presence of node_modules/
vlaurin
force-pushed
the
58-module-not-found
branch
from
6822916 to
d43f7fb
Compare
vlaurin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
This ensures that the action solely relies on the minimised distributable and not on elements from node_modules/ directory which is not checked in.