use db_version for col_version #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantaman
added a commit
that referenced
this pull request
Oct 13, 2023
1. We compact out side ids so there isn't much advantage to making it null for local writes anymore 2. This cleans up the interface so users don't have to do weird coalescing 3. This allows us to make #386 a reality by switching tie breaks to site_ids
tantaman
added a commit
that referenced
this pull request
Oct 13, 2023
1. We compact out side ids so there isn't much advantage to making it null for local writes anymore 2. This cleans up the interface so users don't have to do weird coalescing 3. This allows us to make #386 a reality by switching tie breaks to site_ids
Merged
tantaman
added a commit
that referenced
this pull request
Oct 13, 2023
1. We compact out side ids so there isn't much advantage to making it null for local writes anymore 2. This cleans up the interface so users don't have to do weird coalescing 3. This allows us to make #386 a reality by switching tie breaks to site_ids
tantaman
added a commit
that referenced
this pull request
Oct 13, 2023
1. We compact out side ids so there isn't much advantage to making it null for local writes anymore 2. This cleans up the interface so users don't have to do weird coalescing 3. This allows us to make #386 a reality by switching tie breaks to site_ids
tantaman
added a commit
that referenced
this pull request
Oct 13, 2023
This is to allow us to preserve transactionality of mutations. In conjunction with #386, this'll allow fields to be all set together or all reverted together. Useful for cases where `x` & `y` coordinates are supposed to be updated together or not at all or some such thing.
tantaman
added a commit
that referenced
this pull request
Oct 26, 2023
This is to allow us to preserve transactionality of mutations. In conjunction with #386, this'll allow fields to be all set together or all reverted together. Useful for cases where `x` & `y` coordinates are supposed to be updated together or not at all or some such thing.
tantaman
added a commit
that referenced
this pull request
Oct 30, 2023
This is to allow us to preserve transactionality of mutations. In conjunction with #386, this'll allow fields to be all set together or all reverted together. Useful for cases where `x` & `y` coordinates are supposed to be updated together or not at all or some such thing.
tantaman
force-pushed
the
db-version-col-version
branch
from
1b45a97 to
28cf7f6
Compare
This ensures that if two fields should always change together that they always will as when one loses a merge the other one will also lose the merge. Hmm, except in the case where the clocks are equal and then we tie break on value. Would be better to tie break on peer id for consistency.
tantaman
force-pushed
the
db-version-col-version
branch
from
28cf7f6 to
a286a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if two fields should always change together that they always will as when one loses a merge the other one will also lose the merge.
Hmm, except in the case where the clocks are equal and then we tie break on value. Would be better to tie break on peer id for consistency.