fix skip logic

Signed-off-by: Lucas Wilkinson <[email protected]>
vllm-project · Jan 24, 2025 · 08ecfcc · 08ecfcc
1 parent a482f58
commit 08ecfcc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/tests/kernels/test_cascade_flash_attn.py b/tests/kernels/test_cascade_flash_attn.py
@@ -93,9 +93,9 @@ def test_cascade(
     fa_version: int,
 ) -> None:
     torch.set_default_device("cuda")
-    if is_fa_version_supported(fa_version):
-        pytest.skip("Flash attention version not supported due to: " + \
-                    fa_version_unsupported_reason(fa_version))
+    if not is_fa_version_supported(fa_version):
+        pytest.skip(f"Flash attention version {fa_version} not supported due "
+                    f"to: \"{fa_version_unsupported_reason(fa_version)}\"")
 
     current_platform.seed_everything(0)
 

diff --git a/tests/kernels/test_flash_attn.py b/tests/kernels/test_flash_attn.py
@@ -97,8 +97,8 @@ def test_flash_attn_with_paged_kv(
     fa_version: int,
 ) -> None:
     torch.set_default_device("cuda")
-    if is_fa_version_supported(fa_version):
-        pytest.skip(f"Flash attention version {fa_version} not supported due  "
+    if not is_fa_version_supported(fa_version):
+        pytest.skip(f"Flash attention version {fa_version} not supported due "
                     f"to: \"{fa_version_unsupported_reason(fa_version)}\"")
 
     current_platform.seed_everything(0)
@@ -183,8 +183,8 @@ def test_varlen_with_paged_kv(
     fa_version: int,
 ) -> None:
     torch.set_default_device("cuda")
-    if is_fa_version_supported(fa_version):
-        pytest.skip(f"Flash attention version {fa_version} not supported due  "
+    if not is_fa_version_supported(fa_version):
+        pytest.skip(f"Flash attention version {fa_version} not supported due "
                     f"to: \"{fa_version_unsupported_reason(fa_version)}\"")
     current_platform.seed_everything(0)
     num_seqs = len(seq_lens)