[core][misc] keep compatibility for old-style classes #10356
Conversation
Signed-off-by: youkaichao <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
| @@ -99,13 +99,34 @@ def _initialize_model(vllm_config: VllmConfig, prefix: str = "") -> nn.Module: | |||
| param.name for param in signatures.parameters.values() | |||
| if param.kind == inspect.Parameter.KEYWORD_ONLY | |||
There was a problem hiding this comment.
Can we allow POSITIONAL_OR_KEYWORD arguments as well?
There was a problem hiding this comment.
relaxed the constraint to only vllm_config and prefix . does it sound good to you?
Signed-off-by: youkaichao <[email protected]>
github-actions
bot
added
the
ready
…0356) Signed-off-by: youkaichao <[email protected]>
…0356) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…0356) Signed-off-by: youkaichao <[email protected]> Signed-off-by: rickyx <[email protected]>
…0356) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…0356) Signed-off-by: youkaichao <[email protected]>
#10304 will be too annoying for users. let's keep the compatibility for a while, and only give a warning first.