Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][Bugfix] Support TP for PixtralHF ViT #10405

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Nov 17, 2024

Currently running a PixtralHF model with TP will cause an input shape error while profiling through ViT attention:

RuntimeError: Error in model execution (input dumped to /tmp/err_execute_model_input_20241117-211655.pkl): shape '[1, 20480, 16, 64]' is invalid for input of size 5242880

Verified with MMMU eval on an FP8 model

Server:

vllm serve nm-testing/pixtral-12b-FP8-dynamic --max-num-seqs 30 --max-model-len 30000 --limit-mm-per-prompt image=5 --tensor-parallel-size 4

Client:

python -m eval.run eval_vllm --model_name nm-testing/pixtral-12b-FP8-dynamic --url http://0.0.0.0:8000 --output_dir output/ --eval_name "mmmu"
Waiting for VLLM server to come online at http://0.0.0.0:8000/health ...
Timeout is 120s
Waiting for server (0s) ...
Server is up!
Loading lmms-lab/MMMU [validation]: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 900/900 [00:10<00:00, 89.20it/s]
Querying model: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 900/900 [01:52<00:00,  7.99it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 900/900 [00:00<00:00, 13029.97it/s]
================================================================================
Metrics:
{
    "explicit_prompt_relaxed_correctness": 0.51,
    "anywhere_in_answer_relaxed_correctness": 0.51
}
================================================================================

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 17, 2024
@mgoin mgoin changed the title [Model] Support TP for PixtralHF ViT [Model][Bugfix] Support TP for PixtralHF ViT Nov 17, 2024
@DarkLight1337
Copy link
Member

There seems to be some issue with V1 eval.

@simon-mo simon-mo merged commit 281cc4b into vllm-project:main Nov 18, 2024
63 of 68 checks passed
mikejuliet13 pushed a commit to mikejuliet13/vllm that referenced this pull request Nov 19, 2024
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 3, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants