-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Create a new "Usage" section #10827
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: DarkLight1337 <[email protected]>
700fc8d
to
7710e7f
Compare
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
f9a14b1
to
c5da5fe
Compare
Signed-off-by: DarkLight1337 <[email protected]>
cc @ywang96 since I have significantly modified the docs for VLMs. |
Signed-off-by: DarkLight1337 <[email protected]>
a2f2955
to
449eef6
Compare
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thank you for using git mv
! It's really common for people to not do that and accidentally lose the git history of the file.
There are two things I'm thinking about when deciding on groupings of content:
- who is the audience? (someone running vLLM, someone interacting with it via the API, using it via Python, someone working on the vLLM code, probably others)
- what problem are they trying to solve?
In this PR, I thought maybe you wanted "Serving" to focus more on "someone running vLLM", but that doesn't seem right. There are deploying docs that stay, but. then the doc on environment variables that a deployer would set got moved.
How would you describe the intended audience and scope of each section?
There are some in the PR that make a lot of sense to move around. A couple examples are "Adding a New Model" and "Enabling Multimodal Inputs". Those are more like "Design" to me. The audience is "people working on the vLLM code," and the content for that audience has been shifted to the end of the docs recently.
+1 i think we can expand the scope for broader refactoring of the doc tree, but okay to keep it scoped smaller. |
Actually, I didn't use it. The diffs were small enough that Git was able to detect that automatically 😅 Thanks for telling me about this though.
vLLM supports both offline and online inference. I intend the Usage section to contain docs that apply to both. On the other hand, the Serving section focuses on online inference only.
I agree that those two pages should be moved elsewhere. It's not really about "Design" though, maybe we can add a new Tutorials section? In any case it's outside the scope of this PR. |
Oh, I see. GitHub was smart enough to detect it and show it that way in the UI, but It's up to you if you feel like this is worth fixing.
Yeah, I guess I don't know how to decide what would go under
That's fine. I actually like how it is now that I look again. All of the content under "Models" groups together nicely. |
I'm not too bothered by this, since |
Does this look good to you now? |
I'm not opposed to it. Definitely don't let me block it. I'm still not sure I understand it, though:
but please feel free to proceed if you'd like. It can always be changed further. |
Yeah, perhaps it would be clearer as we make further changes down the line. @simon-mo can you stamp this? |
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Some of the pages under "Serving" and "Models" aren't really related to their parent section. This PR creates a new "Usage" section to accommodate these pages.
@simon-mo can you help set up redirects as requested in #10428?Done