[V1] Make AsyncLLMEngine v1-v0 opaque #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Ricky Xu <[email protected]>
rickyyx
force-pushed
the
ricky/v1-async-engine
branch
from
0ab6855 to
2604dbc
Compare
comaniac
approved these changes
Dec 20, 2024
comaniac
added
ready
|
Test failures look unrelated on AMD. |
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Ricky Xu <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Ricky Xu <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Ricky Xu <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Ricky Xu <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Ricky Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, users of the AsyncLLMEngine will have to modify their code to use V1 even if
VLLM_USE_V1=1is used.We should have the V1/V0 behaviour changed by
VLLM_USE_V1sorely as much as possible.