Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][AMD] Add information about prebuilt ROCm vLLM docker for perf validation purpose #12281

Merged

Conversation

hongxiayang
Copy link
Collaborator

@hongxiayang hongxiayang commented Jan 21, 2025

Added information about prebuilt vLLM on ROCm docker for validation of performance on MI300x node.

This is to address the request from PR. We will close/cancel that PR after this is merged.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 21, 2025
@hongxiayang hongxiayang changed the title [Documentation][AMD] Add information about prebuilt vLLM on ROCm docker for perf validation purpose [Documentation][AMD] Add information about prebuilt ROCm vLLM docker for perf validation purpose Jan 21, 2025
Signed-off-by: Hongxia Yang <[email protected]>
Signed-off-by: Hongxia Yang <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 21, 2025
@mgoin
Copy link
Member

mgoin commented Jan 21, 2025

Thanks!

@DarkLight1337 DarkLight1337 merged commit 09ccc9c into vllm-project:main Jan 21, 2025
37 of 39 checks passed
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
…for perf validation purpose (vllm-project#12281)

Signed-off-by: Hongxia Yang <[email protected]>
Signed-off-by: Bowen Wang <[email protected]>
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
tjtanaa pushed a commit to EmbeddedLLM/vllm that referenced this pull request Jan 28, 2025
@hmellor
Copy link
Collaborator

hmellor commented Jan 30, 2025

This should have gone in the Pre-built images section. I will move it.

rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
…for perf validation purpose (vllm-project#12281)

Signed-off-by: Hongxia Yang <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants