[Misc] Fix the error in the tip for the --lora-modules parameter #12319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
jeejeelee
approved these changes
Jan 22, 2025
Signed-off-by: wangerxiao <[email protected]>
WangErXiao
force-pushed
the
frontend-fix-tip
branch
from
9f74987 to
6662aeb
Compare
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]>
tjtanaa
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Jan 27, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]>
tjtanaa
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Jan 27, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]>
tjtanaa
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Jan 28, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]>
rasmith
pushed a commit
to rasmith/vllm
that referenced
this pull request
Jan 30, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]>
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Feb 2, 2025
…m-project#12319) Signed-off-by: wangerxiao <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LoRAModulePath only contains three fields ('name', 'path', and 'base_model_name') and does not include a 'local_path' field, attempting to use 'local_path' caused an error as indicated by the usage tip. Therefore, update the tip error message to reflect this.